Skip to content

chore: swiftlint should not lint node_modules#2463

Merged
tido64 merged 1 commit into
trunkfrom
tido/swiftlint-exclude-node-modules
May 5, 2025
Merged

chore: swiftlint should not lint node_modules#2463
tido64 merged 1 commit into
trunkfrom
tido/swiftlint-exclude-node-modules

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented May 5, 2025 •
edited
Loading

Description

swiftlint should not lint node_modules:

% yarn lint:swift
Linting Swift files in current working directory
[...]
/~/node_modules/@react-native-community/template/template/ios/HelloWorld/AppDelegate.swift:8:135: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
/~/node_modules/@react-native-community/template/template/ios/HelloWorld/AppDelegate.swift:8:1: warning: Line Length Violation: Line should be 120 characters or less; currently it has 159 characters (line_length)
[...]
Done linting! Found 2 violations, 0 serious in 16 files.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

@tido64 tido64 requested a review from JasonVMo as a code owner May 5, 2025 12:35
@Saadnajmi
Copy link
Copy Markdown
Collaborator

Saadnajmi commented May 5, 2025

Note: maybe the template app can have a swiftlint config file added to it? Out of scope of this repo though

@tido64 tido64 merged commit d6003bc into trunk May 5, 2025
30 checks passed
@tido64 tido64 deleted the tido/swiftlint-exclude-node-modules branch May 5, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @Saadnajmi